Fixed to show spinner on data load #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed the issue where, when showing the spinner, the iron-collapse does not always open. Note that this collapse bug did exist in version 1,10 too,
nfelt
approved these changes
Oct 10, 2018
| @@ -120,7 +119,8 @@ export const DataLoaderBehavior = { | |||
|
|
|||
| if (!this.isAttached) return; | |||
| this._loadDataAsync = this.async(() => { | |||
| this.dataLoading = true; | |||
| // Using a setter does not notify the impl observers. | |||
There was a problem hiding this comment.
Hmm, this is basically the same issue as the loadKey issue, right? So it seems like maybe the behavior observer/property connection is buggy or broken somehow.
| @@ -140,7 +140,7 @@ export const DataLoaderBehavior = { | |||
| }); | |||
|
|
|||
| return Promise.all(promises).then(this._canceller.cancellable(result => { | |||
| this.dataLoading = false; | |||
| this.set('dataLoading', false); | |||
There was a problem hiding this comment.
Can you add the same comment here?
| @@ -58,7 +58,6 @@ export const DataLoaderBehavior = { | |||
|
|
|||
| dataLoading: { | |||
| type: Boolean, | |||
| readOnly: true, | |||
There was a problem hiding this comment.
Does this have to be non-readOnly in order to use set()? It's still logically readonly though, right?
There was a problem hiding this comment.
Ah, you were correct! I always forget that you ned to use a special setter when setting a value to a readOnly property. I changed other codes to use this._setDataLoading and kept this readOnly. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed the issue where, when showing the spinner, the iron-collapse
does not always open. Note that this collapse bug did exist in version
1,10 too,